fix(icm20948): Setting bit in wrong register / typo#606
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the ICM20948 component where the gyroscope digital low-pass filter (DLPF) enable bit was being set in the wrong register. The function set_gyroscope_dlpf_enabled was writing to GYRO_CONFIG_2 instead of GYRO_CONFIG_1, which prevented the DLPF from being enabled and sometimes caused errors.
Changes:
- Corrected register reference in
set_gyroscope_dlpf_enabled()fromGYRO_CONFIG_2toGYRO_CONFIG_1to match the datasheet specification and existing code comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GYRO_CONFIG_1instead ofGYRO_CONFIG_2to enable gyro DLPF.Motivation and Context
Closes #605
How has this been tested?
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.